Create concept of 'global plugins' that are added to all instances, and initialized on start screen#5497
Open
Create concept of 'global plugins' that are added to all instances, and initialized on start screen#5497
Conversation
1139042 to
2db0a66
Compare
Collaborator
Author
|
This PR now also makes another change which is to make the desktop app behave more like a 'multi-page app'. It uses 'hash routing'. So instead of having complex logic for managing whether we are on the start screen or in the main app, that is determined by literlly navigating to a hash route that says whether we are in the app Just as a bit of a zoom out, it is nice to break out of the single-page app mindset...multi page apps can do things quite well, particularly when it makes clear sense for there to be multiple pages like the start screen vs jbrowse app Other pages could potentially be developed too...hash router could even be developed for jbrowse web |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible solution to making Apollo a more 'first class' system for users
It creates the concept of a 'global set of plugins' that will be initialized at the start screen, and also added to all instances
This PR allows plugins to also customize the appearence of the start page by creating a system for swapping out components
It does so by creating a new concept that leverages extension points called PluginComponents, which can be used like this